Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #947

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Patch 1 #947

wants to merge 11 commits into from

Conversation

Novfensec
Copy link

@Novfensec Novfensec commented Nov 22, 2024

To support the latest pillow version, need to install these dependencies:

brew update
brew install autoconf automake libtool pkg-config libjpeg libtiff webp little-cms2

Updated README.md with latest command.

hemna and others added 6 commits November 18, 2024 10:49
itsdangerous version 2.2.0 eliminated their setup.py, so all
toolchain builds of itsdangerous fails due to missing setup.py.

This patch updates the recipe for itsdangerous to run pip to
install the 2.2.0 version.
The build for Pillow 11.0.0 doesn't work from this file
without this change due to the original url scheme not working.
Updated the pillow url to go to github to fetch the tar ball.
itsdangerous version 2.2.0 eliminated their setup.py, so all
toolchain builds of itsdangerous fails due to missing setup.py.

This patch updates the recipe for itsdangerous to run pip to
install the 2.2.0 version.
@Novfensec
Copy link
Author

Please wait till Its ready for review.

@Novfensec Novfensec marked this pull request as ready for review November 22, 2024 11:12
@Novfensec
Copy link
Author

@AndreMiras
Updated README.md with latest commands.
The pull-request can be merged.

AndreMiras
AndreMiras previously approved these changes Nov 22, 2024
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.
Did you get a chance to test it runtime?
Let's see what the CI says at compile time.
Also it's not clear if the bitarray recipe is just an extra recipe you thought was nice to have or if it's actually used by pillow?

kivy_ios/recipes/pillow/__init__.py Outdated Show resolved Hide resolved
@Novfensec
Copy link
Author

LGTM thanks.
Did you get a chance to test it runtime?
Let's see what the CI says at compile time.
Also it's not clear if the bitarray recipe is just an extra recipe you thought was nice to have or if it's actually used by pillow?

It adds to the existing recipes. I have used it in one of my projects and might someone else find errors packaging it to ios,so to save from errors.

@Novfensec
Copy link
Author

removed commented line and added a line at then end of bitarray/init.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants